Omer Frenkel has posted comments on this change. Change subject: engine: support non-unique vm and template names across DCs (#912263) ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41263/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 141: Line 142: // VM Template based entities queries Line 143: IsVmTemlateWithSameNameExist(VdcQueryAuthType.User), Line 144: GetVmTemplate(VdcQueryAuthType.User), Line 145: GetInstanceType(VdcQueryAuthType.User), are you sure this should be user query? where are you using it? Line 146: GetAllVmTemplates(VdcQueryAuthType.User), Line 147: GetAllInstanceTypes(VdcQueryAuthType.User), Line 148: GetAllImageTypes(VdcQueryAuthType.User), Line 149: GetVmTemplatesDisks(VdcQueryAuthType.User), -- To view, visit https://gerrit.ovirt.org/41263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f3244ec1885d54e58b475d0e74f59e26fa492a0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
