Piotr Kliczewski has posted comments on this change. Change subject: engine: Network errors should be handled specifically ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/41529/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 739: if (cachedVds.getStatus() != VDSStatus.Down) { Line 740: long timeoutToFence = calcTimeoutToFence(cachedVds.getVmCount(), cachedVds.getSpmStatus()); Line 741: if (isHostInGracePeriod(false)) { Line 742: if (cachedVds.getStatus() != VDSStatus.Connecting Line 743: && cachedVds.getStatus() != VDSStatus.Unassigned Is this really needed once we have change in VdsBrokerCommand? Line 744: && cachedVds.getStatus() != VDSStatus.PreparingForMaintenance Line 745: && cachedVds.getStatus() != VDSStatus.NonResponsive) { Line 746: setStatus(VDSStatus.Connecting, cachedVds); Line 747: logChangeStatusToConnecting(timeoutToFence); https://gerrit.ovirt.org/#/c/41529/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java: Line 98: @Override Line 99: protected void executeVDSCommand() { Line 100: try { Line 101: executeVdsBrokerCommand(); Line 102: } catch (VDSNetworkException ex) { Why do we want to additional catch for networking exception? We already handle it as part of XmlRpcRunTimeException. I suggest to reorder catch blocks to handle generic VDSExceptionBase last and reuse existing block by using multi-catch. Line 103: printReturnValue(); Line 104: updateNetworkException(ex, ex.getMessage()); Line 105: networkError.fire(ex); Line 106: throw ex; -- To view, visit https://gerrit.ovirt.org/41529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0964537f91c0f3db07ef244cf41cbb1bbb58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
