Tomas Jelinek has posted comments on this change. Change subject: Mark VM as problematic when timezone or OS changed ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/30508/16/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java: Line 175: if (javaZoneId != null) { Line 176: offset = TimeZoneType.GENERAL_TIMEZONE.getStandardOffset(javaZoneId); Line 177: } Line 178: Line 179: if(vm.getGuestOsTimezoneOffset() != offset) { Still not sure - this expression says that when the vm.getTimeZone() == null than the offset == 0. Is that correct? Line 180: return true; Line 181: } Line 182: } Line 183: -- To view, visit https://gerrit.ovirt.org/30508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1d6c878a3e700998c77d3ee3248b4ef3302d08b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
