Martin Betak has uploaded a new change for review. Change subject: frontend: Fix random focus change in host main tab ......................................................................
frontend: Fix random focus change in host main tab The HostListModel was missing the appropriate HashName property that would match the last part of place token, and thus the GWT-P reveal failed for non-existing place 'hosts-undefined'. Also added missing help-tag and title. Change-Id: Ib232da07c49b7329729f29c00e5013a5d4bb5206 Signed-off-by: Martin Betak <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/HostDeviceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java 3 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/41841/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java index 12f3f0f..01fd691 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java @@ -608,6 +608,8 @@ host_devices("host_devices", HelpTagType.UNKNOWN), //$NON-NLS-1$ + vm_host_devices("vm_host_devices", HelpTagType.UNKNOWN), //$NON-NLS-1$ + add_host_device("add_host_device", HelpTagType.WEBADMIN, "VMs Tab > Host Devices Sub-Tab > Add Host Device(s)"), //$NON-NLS-1$ //$NON-NLS-2$ remove_host_device("remove_host_device", HelpTagType.WEBADMIN, "VMs Tab > Host Devices Sub-Tab > Remove Host Device(s)"), //$NON-NLS-1$ //$NON-NLS-2$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/HostDeviceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/HostDeviceListModel.java index 0cc0ad2..8d94274 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/HostDeviceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/HostDeviceListModel.java @@ -1,10 +1,21 @@ package org.ovirt.engine.ui.uicommonweb.models.vms.hostdev; +import com.google.inject.Inject; import org.ovirt.engine.core.common.businessentities.VDS; import org.ovirt.engine.core.common.queries.IdQueryParameters; import org.ovirt.engine.core.common.queries.VdcQueryType; +import org.ovirt.engine.ui.uicommonweb.help.HelpTag; +import org.ovirt.engine.ui.uicompat.UIConstants; public class HostDeviceListModel extends HostDeviceListModelBase<VDS> { + + @Inject + public HostDeviceListModel(UIConstants constants) { + setTitle(constants.hostDevicesTitle()); + setHelpTag(HelpTag.host_devices); + setHashName("devices"); + } + @Override protected String getListName() { return "HostDeviceListModel"; //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java index 8e8f377..d3b3819 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java @@ -36,7 +36,7 @@ this.constants = constants; setTitle(constants.hostDevicesTitle()); - setHelpTag(HelpTag.host_devices); + setHelpTag(HelpTag.vm_host_devices); setHashName("host_devices"); //$NON-NLS-1$ setAddCommand(new UICommand("New", this)); //$NON-NLS-1$ -- To view, visit https://gerrit.ovirt.org/41841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib232da07c49b7329729f29c00e5013a5d4bb5206 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
