Oved Ourfali has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/37488/18/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java: Line 12: public class RefresherFactory { Line 13: Line 14: public static VMStatsRefresher create(final VdsManager manager, final AuditLogDirector auditLogDirector, final SchedulerUtil scheduler) { Line 15: Version version = manager.getCompatibilityVersion(); Line 16: if (FeatureSupported.jsonProtocol(version) && FeatureSupported.vmStatsEvents(version)) { is it possible to have FeatureSupported for the vm stats event, but json isn't? Also, the host might have jsonrpc disabled, will you catch that? Although for 3.6 cluster we'll have it that way automatically, but we need to consider what to do when upgrading clusters. Perhaps only engine restart will turn it into jsonrpc. Line 17: return new EventVMStatsRefresher(manager, auditLogDirector, scheduler); Line 18: } Line 19: return new PollVMStatsRefresher(manager, auditLogDirector, scheduler); Line 20: } -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
