Martin Mucha has posted comments on this change. Change subject: engine: Add NetworkAttachmentValidator ......................................................................
Patch Set 30: ad: "Why are the tests in a much later patch? Please merge them to this patch." — I just tried to change order of few validators & theirs tests. Some conflicts (missing file, extra file) started to appear. They probably won't be hard to fix, but it's not worth it to spent much time on it and risk potential of creating error. -- To view, visit https://gerrit.ovirt.org/33331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908511f4c0f999d82120074c290eccd9e1006cdc Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
