Maor Lipchuk has posted comments on this change. Change subject: core: added CRUD commands for LibvirtSecrets ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/41555/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java: Line 46: "org.ovirt.engine.core.bll.numa.vm", Line 47: "org.ovirt.engine.core.bll.pm", Line 48: "org.ovirt.engine.core.bll.provider", Line 49: "org.ovirt.engine.core.bll.provider.network", Line 50: "org.ovirt.engine.core.bll.provider.storage", How is it related to the patch Line 51: "org.ovirt.engine.core.bll.qos", Line 52: "org.ovirt.engine.core.bll.scheduling.commands", Line 53: "org.ovirt.engine.core.bll.scheduling.queries", Line 54: "org.ovirt.engine.core.bll.profiles", https://gerrit.ovirt.org/#/c/41555/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLibvirtSecretCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLibvirtSecretCommand.java: Line 1: package org.ovirt.engine.core.bll.storage; Should those classes be under storage package? Line 2: Line 3: import org.ovirt.engine.core.bll.provider.storage.LibvirtSecretValidator; Line 4: import org.ovirt.engine.core.common.AuditLogType; Line 5: import org.ovirt.engine.core.common.action.LibvirtSecretParameters; https://gerrit.ovirt.org/#/c/41555/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/LibvirtSecretCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/LibvirtSecretCommandBase.java: Line 37: Line 38: @Override Line 39: protected void executeCommand() { Line 40: Guid secretUuid = getParameters().getLibvirtSecret().getId(); Line 41: addCustomValue("LibvirtSecretUUID", secretUuid.toString()); I didn't understand why you use this here. If you want the audit log to be aware of this field you should use setLibvirtSecretUUID and getLibvirtSecretUUID Line 42: getReturnValue().setActionReturnValue(secretUuid); Line 43: } -- To view, visit https://gerrit.ovirt.org/41555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7278408ca2548b3c66a5eb862b234959c4f1748c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
