Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Propagate the scheduler error to UI ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41822/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java: Line 42: setSucceeded(false); > What about this else case. Here also scheduling fails but we are not showin Actually in case of exception earlier we were returning null from method. Now in such case actually there would be exception and it would always fall under catch case. But may be I can add handleVdsError() call here as well to report error. https://gerrit.ovirt.org/#/c/41822/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java: Line 31: setSucceeded(false); > What about this else case. Here also scheduling fails but we are not showin Same as for earlier source -- To view, visit https://gerrit.ovirt.org/41822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2630cb8701d394da8a658c3ba677616f026625a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
