Francesco Romani has posted comments on this change. Change subject: services, setup: ovirt-vmconsole integration ......................................................................
Patch Set 38: (1 comment) https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovirt-vmconsole-list.py File packaging/services/ovirt-vmconsole-proxy/ovirt-vmconsole-list.py: Line 22: import sys Line 23: import urllib2 Line 24: import urlparse Line 25: Line 26: import config > Already added: I think I got it. The problem should be that here I'm using this python source as script, not as module. Hence, the source is not seen as package (not surprising at all), and this explains the error I reported in the comment above. Please note that __all__ in __init__.py should not be the culprit, because a completely empty __init__.py doesn't help. The above (line 26) import because, quoting https://docs.python.org/2/tutorial/modules.html#the-module-search-path """ the directory containing the input script (or the current directory). """ So, even though is a bit confusing and not the brightest python ever wrote, this should work relaibly. Given the constraints I'm having quite an hard time figuring out a better approach. To reduce the confusion and the name clashing, I can rename config.py to something like vmconsole_config.py, or maybe ovirt-vmconsole-conf.py which is a little better. Besides that, I can't think of anything else. Suggestions very welcome. Line 27: Line 28: from ovirt_engine import configfile, service, ticket Line 29: Line 30: -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
