Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing SEAT
......................................................................
Patch Set 26: I would prefer that you didn't submit this
(2 inline comments)
Technical issue - your patch won't work after the merge of changes to
async_tasks table, sorry :(
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
Line 9: import org.ovirt.engine.core.common.vdscommands.VDSParametersBase;
Line 10: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
Line 11: import org.ovirt.engine.core.compat.Guid;
Line 12:
Line 13: public abstract class AbstractSPMAsyncTaskHandler<C extends
ITaskHandlerCommand<?>> implements SPMAsyncTaskHandler {
Hi,
Personally, I dont like I prefix for interface at Java code.
Can you please change to TaskHandlerCommand?
Line 14:
Line 15: private final C cmd;
Line 16:
Line 17: public AbstractSPMAsyncTaskHandler(C cmd) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 973:
Line 974: protected final void execute() {
Line 975: getReturnValue().setCanDoAction(true);
Line 976: getReturnValue().setIsSyncronious(true);
Line 977: getParameters().setTaskStartTime(System.currentTimeMillis());
Your patch will not work after my last merge, sorry :(
Line 978:
Line 979: ExecutionHandler.addStep(getExecutionContext(),
StepEnum.EXECUTING, null);
Line 980:
Line 981: try {
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
