Ravi Nori has posted comments on this change. Change subject: CommandBase - persist command if the parent command has a callback ......................................................................
Patch Set 2: the problem is the code is executed for all cases with out any check. This code should not be executed for async commands. Probably check if the command already exists in db before persisting. If it exists don't persist -- To view, visit https://gerrit.ovirt.org/41696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If15fad1db94e7a0bdc51d02afc9b952b4e980e4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
