Omer Frenkel has posted comments on this change. Change subject: core: introduce convert vm command ......................................................................
Patch Set 95: (2 comments) https://gerrit.ovirt.org/#/c/33055/95/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java: Line 110: switch (getActionState()) { Line 111: case EXECUTE: Line 112: if (getSucceeded()) { Line 113: return AuditLogType.IMPORTEXPORT_STARTING_CONVERT_VM; Line 114: } but what about failure? Line 115: case END_SUCCESS: Line 116: if (getSucceeded()) { Line 117: return AuditLogType.IMPORTEXPORT_IMPORT_VM; Line 118: } https://gerrit.ovirt.org/#/c/33055/95/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 121: SetMOMPolicyParameters("org.ovirt.engine.core.vdsbroker.vdsbroker"), Line 122: SetHaMaintenanceMode("org.ovirt.engine.core.vdsbroker.vdsbroker"), Line 123: ConvertVm("org.ovirt.engine.core.vdsbroker.vdsbroker"), Line 124: GetConvertedOvf("org.ovirt.engine.core.vdsbroker.vdsbroker"), Line 125: DeleteV2VJob("org.ovirt.engine.core.vdsbroker.vdsbroker"), no new vdsm errors for these commands? Line 126: // Gluster VDS commands Line 127: CreateGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 128: SetGlusterVolumeOption("org.ovirt.engine.core.vdsbroker.gluster"), Line 129: ResetGlusterVolumeOptions("org.ovirt.engine.core.vdsbroker.gluster"), -- To view, visit https://gerrit.ovirt.org/33055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bc67ff237d5c01fc5f3c9f21c822573e5db32a3 Gerrit-PatchSet: 95 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
