Eli Mesika has posted comments on this change. Change subject: engine: Fix Bz.1219830 and Bz.1224697 ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42009/2/packaging/dbscripts/upgrade/03_06_1490_insert_and_update_config_description.sql File packaging/dbscripts/upgrade/03_06_1490_insert_and_update_config_description.sql: Line 6: UPDATE gluster_config_master SET config_key='gluster_log_file' WHERE config_key='gluster-log-file'; Line 7: Line 8: UPDATE gluster_config_master SET config_key='ignore_deletes', config_possible_values='true;false' WHERE config_key='ignore-deletes'; Line 9: Line 10: UPDATE gluster_config_master SET config_key='ssh_command' WHERE config_key='ssh-command'; This can be UPDATE gluster_config_master SET config_key= CASE WHEN 'log-file' THEN 'log_file' WHEN 'gluster-log-file' THEN 'gluster_log_file' WHEN 'ignore-deletes' THEN 'ignore_deletes' WHEN 'ssh-command' THEN 'ssh_command' END; and you have another separate update for the config_possible_values='true;false' WHERE config_key='ignore-deletes'; -- To view, visit https://gerrit.ovirt.org/42009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d1defdf69cb256a2a872a82a5e54dc6abf6d77b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
