Allon Mureinik has posted comments on this change. Change subject: core: MoveDisk - pass WipeAfterDelete property ......................................................................
Patch Set 1: (1 inline comment) Please remove the postZero parameter from the MoveOrCopyImageGroupParameters, as it will no longer be used after this change. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java Line 77: getParameters() Line 78: .getCopyVolumeType(), Line 79: getParameters().getVolumeFormat(), Line 80: getParameters() Line 81: .getVolumeType(), This should be changed to getImage().isWipeAfterDelete() too. Line 82: getParameters().getPostZero(), Line 83: getParameters() Line 84: .getForceOverride(), Line 85: getStoragePool().getcompatibility_version().toString())); -- To view, visit http://gerrit.ovirt.org/8794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f422e5b20853b5f9769736b15f95d26881ea469 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
