Michael Kublin has posted comments on this change.
Change subject: core: Live Storage Migration commands
......................................................................
Patch Set 32: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDiskCommand.java
Line 37: private VM vmForDisk = null;
Line 38: private boolean isVmForDiskInitilized = false;
Line 39: private CommandBase<? extends MoveOrCopyImageGroupParameters> cmd;
Line 40:
Line 41: @Override
Allon, try to calculate a calls that is done in the following code, I
understand that it is difficult but u wrote a patch. When you will do these I
hove u will understand why such approach is bad. I will help you, take a simple
case : freeLock() metho, how many times it was called?
Line 42: protected void executeCommand() {
Line 43: cmd.execute();
Line 44: handleChildReturnValue();
Line 45: }
--
To view, visit http://gerrit.ovirt.org/8105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I253891a0a18863086e36a9b17d008cebbc77adc1
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
