Omer Frenkel has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/37488/19/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java: Line 89: VmInternalData vmData = fetchStats(dbVm, vdsmVm); Line 90: if (vmData != null) { Line 91: changedVms.add(new Pair<>(dbVm, vmData)); Line 92: } Line 93: if (isDevicesChanged(dbVm, vdsmVm)) { > what is buggy in this code? vdsmVm does not contain the has (we can see that it is not set from vdsm response) so it will always be null, and isDevicesChanged will always return false because it is checking if its null. if we would send vmData, then the hash would be set there and we would get true when hash changed Line 94: devicesChangedVms.add(new Pair<>(dbVm, vdsmVm)); Line 95: } Line 96: } Line 97: } -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
