Mike Kolesnik has posted comments on this change.
Change subject: core: Adding UnitTest in VmNetworkInterfaceDao
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java
Line 260:
Line 261: @Test
Line 262: public void testGetAllForNetwork() throws Exception {
Line 263: List<VmNetworkInterface> result =
dao.getAllForNetwork(FixturesTool.NETWORK_ENGINE);
Line 264: assertEquals(existingVmInterface, result.get(0));
Perhaps better to test if the returned list contains the expected interface?
Line 265: }
Line 266:
Line 267: private void
assertCorrectResultForTemplate(List<VmNetworkInterface> result) {
Line 268: assertNotNull(result);
--
To view, visit http://gerrit.ovirt.org/8710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3201bb0734f08d8e41e584fd45589e73867b281d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
