Maor Lipchuk has posted comments on this change. Change subject: core: NPE while adding lun disks (#869596) ......................................................................
Patch Set 1: (2 inline comments) logic looks good to me, see minor comments on commit message .................................................... Commit Message Line 8: Line 9: fixing regression that was introduced in patch with Line 10: change id I8cb77b017282733d72ff66af499b576674674e01 Line 11: Line 12: while adding a disk there an attempt to check the storage domain s/there an attempt/there is an attempt Line 13: of the disk in order to verify whether the added disk storage needs to be Line 14: wiped after it's deletion, lun disks don't have storage domain and can't be Line 15: wiped which caused to NPE. Line 16: Line 9: fixing regression that was introduced in patch with Line 10: change id I8cb77b017282733d72ff66af499b576674674e01 Line 11: Line 12: while adding a disk there an attempt to check the storage domain Line 13: of the disk in order to verify whether the added disk storage needs to be I'm not sure I follow the phrase "the added disk storage..." are you referring to the disk space? Line 14: wiped after it's deletion, lun disks don't have storage domain and can't be Line 15: wiped which caused to NPE. Line 16: Line 17: Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637 -- To view, visit http://gerrit.ovirt.org/8821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
