Maor Lipchuk has posted comments on this change. Change subject: core: getAllByStoragePoolIdFilteredByActiveStorageDomains ......................................................................
Patch Set 9: (1 comment) looks that the stored procedure in the DAO is different from the Stored Procedure in the _sp file. Did I missed anything? https://gerrit.ovirt.org/#/c/41563/9/packaging/dbscripts/libvirt_secrets_sp.sql File packaging/dbscripts/libvirt_secrets_sp.sql: Line 98: END; $procedure$ Line 99: LANGUAGE plpgsql; Line 100: Line 101: Line 102: Create or replace FUNCTION GetLibvirtSecretsByPoolIdOnActiveDomains(v_storage_pool_id UUID) Where is getAllByStoragePoolIdFilteredByActiveStorageDomains which was declared in LibvirtSecretDaoDbFacadeImpl Line 103: RETURNS SETOF libvirt_secrets STABLE Line 104: AS $procedure$ Line 105: BEGIN Line 106: RETURN QUERY SELECT libvirt_secrets.* -- To view, visit https://gerrit.ovirt.org/41563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae886c19afbabd11f013b17e5d304aaf9c199b09 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
