Daniel Erez has posted comments on this change. Change subject: core: register secrets on ConnectHostToStoragePoolServersCommand ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/41564/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java: Line 6: import java.util.Map; Line 7: import java.util.Set; Line 8: Line 9: import org.ovirt.engine.core.bll.InternalCommandAttribute; Line 10: import org.ovirt.engine.core.bll.context.CommandContext; > not relevant to the patch Done Line 11: import org.ovirt.engine.core.common.AuditLogType; Line 12: import org.ovirt.engine.core.common.action.StoragePoolParametersBase; Line 13: import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; Line 14: import org.ovirt.engine.core.common.businessentities.StorageServerConnections; Line 65: Line 66: protected boolean registerLibvirtSecrets(List<LibvirtSecret> libvirtSecrets, boolean clearUnusedSecrets) { Line 67: VDSReturnValue returnValue = runVdsCommand( Line 68: VDSCommandType.RegisterLibvirtSecrets, Line 69: new RegisterLibvirtSecretsVDSParameters(getVdsId(), libvirtSecrets, clearUnusedSecrets)); > you should put here try catch block Done Line 70: if (!returnValue.getSucceeded()) { Line 71: auditLogDirector.log(new AuditLogableBase(getVdsId()), Line 72: AuditLogType.FAILED_TO_REGISTER_LIBVIRT_SECRET_ON_VDS); Line 73: log.error("Failed to register libvirt secret on vds {}.", getVds().getName()); -- To view, visit https://gerrit.ovirt.org/41564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bdeae25b6e4317c8b824fc7df3306e90225585 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
