anmolbabu has posted comments on this change. Change subject: engine: Mount-Broker setup on only one node. ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/39770/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java: Line 33: import org.ovirt.engine.core.dao.gluster.GlusterGeoRepDao; Line 34: import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil; Line 35: Line 36: public class CreateGlusterVolumeGeoRepSessionCommand extends GlusterVolumeCommandBase<GlusterVolumeGeoRepSessionParameters> { Line 37: > Please format class Done Line 38: private GlusterVolumeEntity slaveVolume; Line 39: private Set<VDS> remoteServersSet; Line 40: private VDS slaveHost; Line 41: Line 126: > where is the remoteServerSet populated? canDoAction calls areAllRemoteServersUp which sets the class field remoteServersSet. This is done only to avoid repeated computaion Line 188: > typo - remoteServerSet ? Done Line 195: > currentRemoteHostId ? Done -- To view, visit https://gerrit.ovirt.org/39770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09f44f8f12e5a49a85b3542793aa5f476ab0ccb3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
