Daniel Erez has posted comments on this change. Change subject: restapi: openstack_volume_type on Disk entity ......................................................................
Patch Set 1: @Juan - I'm afraid that the proposed suggestions could be a bit problematic.. since the volume_type objects are merely fetched from OpenStack Cinder (i.e. we're not saving it in the engine DB). Hence, adding a reference for the openstack_volume_type in DiskMapper would require fetching the data from Cinder again. Since the volume_types collection would probably be removed in 4.0 (as the future design for Cinder integration is in planning), it's seems redundant to save the data in our DB (btw, volume_type name is unique per provider). What do think? What would be the best approach in this case? -- To view, visit https://gerrit.ovirt.org/41966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I952c431b8f7e7d0508855892b518c43bef9c7b7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
