Yair Zaslavsky has posted comments on this change.

Change subject: core: Renamed POSIXFSStorageHelper.java to 
PosixFsStorageHelper.java
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Please do not submit this.
Please look at the code, you will see that the helpers are created using 
reflection based on StorageType, which contains an enum value of POSIX.
In addition, this enum value, if I remember correctly cannot be changed to 
Posix, as it is reported by VDSM.

--
To view, visit http://gerrit.ovirt.org/8852
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c43a5c5d62cba5bbd32080adf1cd9e1646e3ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to