Yair Zaslavsky has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 4
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 675: cacheNewValues(quotaVdsGroup, newMemory, newVcpu);
Line 676: return true;
Line 677: } else if (newVcpuPercent <= 100
Line 678: && newMemoryPercent <= 100) { // passed the threshold
(not the quota limit)
Line 679: AUDIT_LOGGER.auditLogVdsGroup(auditLogableBase,
As previously explained, for possible future tests, I would prefer you use a
getQuotaAuditLogger() method.
In general, if we ever move to DI, this should be injected.
Try avoid using singletons they are an evil pattern in a container-based
application.
Line 680:
AuditLogType.USER_EXCEEDED_QUOTA_VDS_GROUP_THRESHOLD,
Line 681: quota.getQuotaName(),
Line 682: vcpuCurrentPercentage + vcpuToAddPercentage,
Line 683: vcpuToAddPercentage,
--
To view, visit http://gerrit.ovirt.org/8779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idab2217b358b5dc53e721297ed16290c4370a363
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
