Yair Zaslavsky has posted comments on this change.
Change subject: core: Quota refactor - VdcActionType
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 5: import org.ovirt.engine.core.common.businessentities.ActionGroup;
Line 6:
Line 7: public enum VdcActionType {
Line 8: Unknown(0, QuotaDependency.NONE),
Line 9: // Vm Commands
Ouch :)
Please remind me - why not having @QuotaDepdency annotation on command classes?
The VdcActionType enum is becoming a monster.
Line 10: AddVm(1, ActionGroup.CREATE_VM, QuotaDependency.NONE),
Line 11: AddVmFromTemplate(2, ActionGroup.CREATE_VM,
QuotaDependency.STORAGE),
Line 12: AddVmFromScratch(3, ActionGroup.CREATE_VM, QuotaDependency.NONE),
Line 13: RemoveVm(4, ActionGroup.DELETE_VM, QuotaDependency.STORAGE),
--
To view, visit http://gerrit.ovirt.org/8780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7677b52b3de80f24c39bc4b3e8ef89d517d53ed6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
