Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: centralized manualSetupDispatcher code ......................................................................
packaging: setup: centralized manualSetupDispatcher code The list of options to manipulate the engine vm is relevant in many parts of the installation process. This patch moves the options list implementation to check_liveliness module and uses it in few events. This code is aimed to be reused on communication errors with the engine vm. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188663 Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11 Signed-off-by: Yaniv Bronhaim <[email protected]> --- M src/ovirt_hosted_engine_setup/check_liveliness.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 4 files changed, 219 insertions(+), 196 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yaniv Bronhaim: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
