Allon Mureinik has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
See minor inline comment regarding the sql script file name.
Ori/Michael - please ack/nack the REST-API part
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1470_change_nfs_version_to_string.sql
Line 1: SELECT
fn_db_change_column_type('storage_server_connections','nfs_version','smallint','varchar(4)');
Note that since this patch was created 03_01_1470_add_smartcard.sql was
introduced.
When you rebase, please rename the file to
03_01_1480_change_nfs_version_to_string.sql
--
To view, visit http://gerrit.ovirt.org/8797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d82db7c0ec92135cae8935f013487e97b8f357
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
