Maor Lipchuk has uploaded a new change for review. Change subject: core: Make remove Cinder disks call back to be generic. ......................................................................
core: Make remove Cinder disks call back to be generic. 1) Rename call back to be more general 2) Use generics so it can be used also for restore Cinder snapshot. Change-Id: I27ed952af20fc315e58c591c1d5eb1042f2dedd1 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Maor Lipchuk <[email protected]> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderDisksCommandCallBack.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/42454/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderDisksCommandCallBack.java similarity index 86% rename from backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java rename to backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderDisksCommandCallBack.java index acc575e..eca0910 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderDisksCommandCallBack.java @@ -4,14 +4,16 @@ import org.ovirt.engine.core.bll.tasks.CommandCoordinatorUtil; import org.ovirt.engine.core.bll.tasks.interfaces.CommandCallback; +import org.ovirt.engine.core.common.action.CloneCinderDisksParameters; import org.ovirt.engine.core.common.action.RemoveAllVmCinderDisksParameters; +import org.ovirt.engine.core.common.action.VmOperationParameterBase; import org.ovirt.engine.core.compat.CommandStatus; import org.ovirt.engine.core.compat.Guid; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class RemoveAllVmCinderDisksCommandCallBack<T extends RemoveAllVmCinderDisksCommand<RemoveAllVmCinderDisksParameters>> extends CommandCallback { - private static final Logger log = LoggerFactory.getLogger(RemoveAllVmCinderDisksCommandCallBack.class); +public class RemoveAllCinderDisksCommandCallBack<T extends CommandBase, S extends VmOperationParameterBase> extends CommandCallback { + private static final Logger log = LoggerFactory.getLogger(RemoveAllCinderDisksCommandCallBack.class); @Override public void doPolling(Guid cmdId, List<Guid> childCmdIds) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java index a926ac6..ebe1900 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java @@ -99,6 +99,6 @@ @Override public CommandCallback getCallback() { - return new RemoveAllVmCinderDisksCommandCallBack<>(); + return new RemoveAllCinderDisksCommandCallBack<>(); } } -- To view, visit https://gerrit.ovirt.org/42454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27ed952af20fc315e58c591c1d5eb1042f2dedd1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
