Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster
......................................................................
Patch Set 4: Looks good to me, approved
(3 inline comments)
looks good,
2 minor comments
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
Line 200: list.add(new ClusterGeneralModel());
Line 201: list.add(new ClusterNetworkListModel());
Line 202: list.add(new ClusterHostListModel());
Line 203: list.add(new ClusterVmListModel());
Line 204: list.add(new ClusterServiceModel());
create a member for ClusterServiceModel
Line 205: list.add(new PermissionListModel());
Line 206: setDetailModels(list);
Line 207: }
Line 208:
Line 207: }
Line 208:
Line 209: @Override
Line 210: protected void UpdateDetailsAvailability() {
Line 211: super.UpdateDetailsAvailability();
set ClusterServiceModel member, no need for instanseof and iteration
Line 212: for (EntityModel detailModel : getDetailModels()) {
Line 213: if (detailModel instanceof ClusterServiceModel) {
Line 214: detailModel.setIsAvailable(((VDSGroup)
getSelectedItem()).supportsGlusterService());
Line 215: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java
Line 62:
Line 63: private UICommand filterServicesCommand;
Line 64:
Line 65: public UICommand getFilterServicesCommand()
Line 66: {
please format the file.
Line 67: return filterServicesCommand;
Line 68: }
Line 69:
Line 70: private void setFilterServicesCommand(UICommand value)
--
To view, visit http://gerrit.ovirt.org/8460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea624f12a07f4aa9b1c6ffa1548aaafb16a00a7a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
