Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 6) ......................................................................
Patch Set 3: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-10-29 17:24:08 +0200 Line 4: Commit: Alona Kaplan <[email protected]> Line 5: CommitDate: 2012-10-29 17:24:08 +0200 Line 6: Line 7: webadmin: Netwrok as Main Tab- (Phase 6) Done Line 8: Line 9: - Cluster sub tab uses new query - GetVdsGroupsAndNetworksByNetworkIdQuery Line 10: - Host sub tab- using new queries. Adding columns. Line 11: - Update networks/networks tree icons. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java Line 29: Line 30: setSetupNetworksCommand(new UICommand("SetupNetworks", this)); //$NON-NLS-1$ Line 31: } Line 32: Line 33: private UICommand privateSetupNetworksCommand; will be done in a cleanup patch Line 34: Line 35: public UICommand getSetupNetworksCommand() Line 36: { Line 37: return privateSetupNetworksCommand; .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java Line 64: Line 65: CheckboxColumn<PairQueryable<VDSGroup, network_cluster>> attachedColumn = new CheckboxColumn<PairQueryable<VDSGroup, network_cluster>>() { Line 66: @Override Line 67: public Boolean getValue(PairQueryable<VDSGroup, network_cluster> object) { Line 68: return object.getFirst() != null; Done Line 69: } Line 70: Line 71: @Override Line 72: protected boolean canEdit(PairQueryable<VDSGroup, network_cluster> object) { -- To view, visit http://gerrit.ovirt.org/8905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5a15afaf4a3c5edb9fce432c8b490e7a15eb76 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
