Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
......................................................................
Patch Set 1: (2 inline comments)
Couple of minor comments in-line.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeProfileInfoReturnForXmlRpc.java
Line 40: private static final String LATENCY_AVG = "latencyAvg";
Line 41: private static final String LATENCY_MIN = "latencyMin";
Line 42: private static final String LATENCY_MAX = "latencyMax";
Line 43:
Line 44: private StatusForXmlRpc mStatus;
I would prefer this to be called 'status'
Line 45:
Line 46: public StatusForXmlRpc getmStatus() {
Line 47: return mStatus;
Line 48: }
Line 129: return blockStatsList;
Line 130: }
Line 131:
Line 132: private Guid getBrickId(List<GlusterBrickEntity> bricksList,
String qualifiedBrickName) {
Line 133: for (GlusterBrickEntity brick : bricksList) {
If you wait till your another patch (http://gerrit.ovirt.org/#/c/7807) is
merged, , or make this one dependent on it, you can reuse
GlusterCoreUtil#getBrickByQualifiedName() here.
Line 134: // Compare the brickname with the existing volume brick
Line 135: if (brick.getQualifiedName().equals(qualifiedBrickName)) {
Line 136: return brick.getId();
Line 137: }
--
To view, visit http://gerrit.ovirt.org/8646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47eb168bd4bcd5f3297a7e89a5ef46e643ed73e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
