Ori Liel has uploaded a new change for review.

Change subject: restapi: #872819 - RSDL Create Lun Disk params
......................................................................

restapi: #872819 - RSDL Create Lun Disk params

RSDL metadata (.yaml file): for direct-LUN disk don't require size, but require 
lun id,
lun type, and lun connection-details (address, target, port).

https://bugzilla.redhat.com/872819

Change-Id: I653b68dce433aa831808b3ea8c5154be00439111
Signed-off-by: Ori Liel <[email protected]>
---
M 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
2 files changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/9021/1

diff --git 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
index 0b769cd..d387da5 100644
--- 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
+++ 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
@@ -2199,7 +2199,7 @@
           <xs:element name="statistics" type="Statistics" minOccurs="0" 
maxOccurs="1"/>
           <xs:element name="active" type="xs:boolean" minOccurs="0"/>
           <xs:element ref="quota" minOccurs="0" maxOccurs="1"/>
-          <xs:element name="lunStorage" type="Storage" minOccurs="0"/>
+          <xs:element name="lun_storage" type="Storage" minOccurs="0"/>
         </xs:sequence>
       </xs:extension>
     </xs:complexContent>
diff --git 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
index 8b3aaeb..6492057 100644
--- 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
+++ 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
@@ -321,7 +321,9 @@
           disk.propagate_errors: xs:boolean
           disk.wipe_after_delete: xs:boolean
           disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}
-      - mandatoryArguments: {disk.interface: 'xs:string', disk.format: 
'xs:string'} #this signature is for direct-LUN disk, which doesn't require size
+        #the signature below is for direct-LUN disk, which doesn't require 
size, but requires the lun id, the lun type, and the lun connection-details.. 
+      - mandatoryArguments: {disk.interface: 'xs:string', disk.format: 
'xs:string', disk.lun_storage.type: 'xs:string',
+          disk.lun_storage.logical_unit--COLLECTION: {logical_unit.id: 
'xs:string', logical_unit.address: 'xs:string', logical_unit.port: 'xs:int', 
logical_unit.target: 'xs:string'}}
         optionalArguments:
           disk.alias: xs:string
           disk.sparse: xs:boolean
@@ -636,7 +638,9 @@
           disk.propagate_errors: xs:boolean
           disk.wipe_after_delete: xs:boolean
           disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}
-      - mandatoryArguments: {disk.interface: 'xs:string', disk.format: 
'xs:string'} #this signature is for direct-LUN disk, which doesn't require size
+        #the signature below is for direct-LUN disk, which doesn't require 
size, but requires the lun id, the lun type, and the lun connection-details.. 
+      - mandatoryArguments: {disk.interface: 'xs:string', disk.format: 
'xs:string', disk.lun_storage.type: 'xs:string',
+          disk.lun_storage.logical_unit--COLLECTION: {logical_unit.id: 
'xs:string', logical_unit.address: 'xs:string', logical_unit.port: 'xs:int', 
logical_unit.target: 'xs:string'}}
         optionalArguments:
           disk.alias: xs:string
           disk.sparse: xs:boolean
@@ -644,7 +648,7 @@
           disk.shareable: xs:boolean
           disk.propagate_errors: xs:boolean
           disk.wipe_after_delete: xs:boolean
-          disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}
+          disk.storage_domains.storage_domain--COLLECTION: 
{storage_domain.id|name: 'xs:string'}          
     urlparams: {}
     headers:
       Content-Type: {value: application/xml|json, required: true}


--
To view, visit http://gerrit.ovirt.org/9021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I653b68dce433aa831808b3ea8c5154be00439111
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to