Michael Kublin has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager
......................................................................
Patch Set 15: (2 inline comments)
additional remarks
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java
Line 6: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase;
Line 7:
Line 8: import java.text.DecimalFormat;
Line 9:
Line 10: public class QuotaManagerAuditLogger {
static ?
Line 11: private final DecimalFormat percentageFormatter = new
DecimalFormat("#.##");
Line 12:
Line 13: protected void auditLogStorage(AuditLogableBase auditLogableBase,
AuditLogType auditLogType, String quotaName,
Line 14: double
storageUsagePercentage,
Line 50: auditLog(auditLogableBase, auditLogType);
Line 51: }
Line 52:
Line 53: protected void auditLog(AuditLogableBase auditLogableBase,
AuditLogType auditLogType) {
Line 54: if (auditLogType != null) {
Again null? How?
Line 55: AuditLogDirector.log(auditLogableBase, auditLogType);
Line 56: }
Line 57: }
Line 58:
--
To view, visit http://gerrit.ovirt.org/8776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb100467a55b26e4219d1a2562da86b81ffdc032
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
