Allon Mureinik has posted comments on this change.
Change subject: core: SEAT - call startPollingAsyncTasks on revert
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 519: private void internalEndWithFailure() {
Line 520: log.errorFormat("Ending command with failure: {0}",
getClass().getName());
Line 521: if (hasTaskHandlers()) {
Line 522: getCurrentTaskHandler().endWithFailure();
Line 523: revertPreviousHandlers();
this is analogous to the startPollingAsyncTasks() call in execute().
This is the first (serious) occurrence that we use tasks for reverting actions.
Line 524: startPollingAsyncTasks();
Line 525: } else {
Line 526: endWithFailure();
Line 527: }
Line 533: log.errorFormat("Reverting task handler: {0}",
getCurrentTaskHandler().getClass().getName());
Line 534:
getParameters().setExecutionReason(CommandExecutionReason.ROLLBACK_FLOW);
Line 535: getCurrentTaskHandler().compensate();
Line 536:
Line 537: if (!hasRevertTask()) {
easier and more readable :-)
Line 538: // If there is no task to take us onwards, just run
the previous handler's revert
Line 539: revertPreviousHandlers();
Line 540: }
Line 541: }
--
To view, visit http://gerrit.ovirt.org/9040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c8fb8fdbf2b89eb6d3949c0eec233d9dc3535dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
