Allon Mureinik has posted comments on this change. Change subject: core: Fix action variable substitution ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) looks OK, assuming this is the only AppErrors the problem appears. Also, note the suggestion for the commit message. .................................................... Commit Message Line 3: AuthorDate: 2012-11-06 11:37:47 +0200 Line 4: Commit: Vered Volansky <[email protected]> Line 5: CommitDate: 2012-11-06 11:41:43 +0200 Line 6: Line 7: core: Fix action variable substitution how about fix attach/detach messages? Line 8: Line 9: Fix VAR__ACTION__ATTACH_ACTION_TO: action substitution was faulty, and Line 10: now is "attach". Line 11: -- To view, visit http://gerrit.ovirt.org/9072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91484360ffa35b3c044695a8277cda491f37b3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
