Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo - introduce libosinfo service
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Not that deep a review because I'm not that knowledgeable with most changes.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmOsType.java
Line 10: OtherLinux(5, OsType.Linux, false, ""),
Line 11: Other(6, OsType.Other, false, ""),
Line 12: RHEL5(7, OsType.Linux, false, "rhel-5.4"),
Line 13: RHEL4(8, OsType.Linux, false, "rhel-4.8"),
Line 14: RHEL3(9, OsType.Linux, false, "rhel-3"),
Maybe it's a libosinfo thing, but why the difference between major and
major.minor? How do you choose the minor version?
Line 15: Windows2003x64(10, OsType.Windows, true, "win2k3"),
Line 16: Windows7(11, OsType.Windows, false,"win7"),
Line 17: Windows7x64(12, OsType.Windows, true,"win7"),
Line 18: RHEL5x64(13, OsType.Linux, true, "rhel-5.4"),
Line 67: }
Line 68:
Line 69: public String getShortId() {
Line 70: return shortId;
Line 71:
Could you remove this empty line?
Line 72: }
--
To view, visit http://gerrit.ovirt.org/8472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I663dbae36d583ca4c524b2957a9a695e44207975
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
