Sharad Mishra has posted comments on this change.
Change subject: engine: Continue reduce usage of getCurrentVdsId()
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java
Line 6: public ResetIrsVDSCommandParameters(Guid storagePoolId, Guid vdsId)
{
Line 7: super(storagePoolId);
Line 8: setVdsId(vdsId);
Line 9: }
Line 10:
was this intentional
Line 11: private Guid privateVdsId;
Line 12:
Line 13: public Guid getVdsId() {
Line 14: return privateVdsId;
....................................................
Commit Message
Line 6:
Line 7: engine: Continue reduce usage of getCurrentVdsId()
Line 8:
Line 9: Reduced usage of getCurrentVdsId() and removed some unused commands
Line 10: The getCurrentVdsId() was used in order to check if there an SPM,
s/there an/there is an
Line 11: the following check is done before call to ExecuteIrsBrokerCommand()
Line 12:
Line 13: Change-Id: Icc8e06fd1814d272788c386ad36e168ec3a9d09d
--
To view, visit http://gerrit.ovirt.org/9026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8e06fd1814d272788c386ad36e168ec3a9d09d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
