Greg Padgett has uploaded a new change for review. Change subject: core: clarify conditional expression in checkImageValidity ......................................................................
core: clarify conditional expression in checkImageValidity Add indentation and parenthesis to improve readability. Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2 Signed-off-by: Greg Padgett <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/9089/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java index a4ac17e7..1af6b76 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java @@ -159,11 +159,11 @@ Guid storagePoolId = diskImage.getstorage_pool_id() != null ? diskImage.getstorage_pool_id().getValue() : Guid.Empty; Guid storageDomainId = - getStorageDomainId() != null && !getStorageDomainId().getValue().equals(Guid.Empty) ? getStorageDomainId() - .getValue() - : diskImage.getstorage_ids() != null && diskImage.getstorage_ids().size() > 0 ? diskImage.getstorage_ids() - .get(0) - : Guid.Empty; + getStorageDomainId() != null && !getStorageDomainId().getValue().equals(Guid.Empty) + ? getStorageDomainId().getValue() + : (diskImage.getstorage_ids() != null && diskImage.getstorage_ids().size() > 0 + ? diskImage.getstorage_ids().get(0) + : Guid.Empty); Guid imageGroupId = diskImage.getId() != null ? diskImage.getId().getValue() : Guid.Empty; -- To view, visit http://gerrit.ovirt.org/9089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
