Arik Hadas has posted comments on this change.
Change subject: engine: Removed unnecessary 'continue' statements
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 188:
Line 189: try {
Line 190: removeServerFromDb(server);
Line 191: // remove the server from resource manager
Line 192: runVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(server.getId()));
I wouldn't put this statement in the try block because if an exception
(RuntimeException) will be thrown during runVdsCommand operation, this
exception will be catched by the catch block (as it catches all exceptions..)
and the log message won't reflect the actual error
I think that it was better the way it was previously with the continue
statement in this case
Line 193: } catch (Exception e) {
Line 194: log.errorFormat("Error while removing server {0}
from database!", server.getvds_name(), e);
Line 195: }
Line 196: }
--
To view, visit http://gerrit.ovirt.org/9083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
