Vinzenz Feenstra has posted comments on this change. Change subject: agent: added win8 and win2012 to reported os version. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve I think it is fine for now, however we should consider changing the part where we distinguish between server and workstation for Win7/Win8 vs 2008R2/2012 Server. I think we could solve this in a more general way. e.g. making the version matrix a tuple where the second value says True for server. -- To view, visit http://gerrit.ovirt.org/9010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d2fdce98479f0d2ecf693c08bb84aff44c4465 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
