Moti Asayag has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
......................................................................
Patch Set 3: (2 inline comments)
minor comment about naming convention
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 290: public static VmDevice addManagedDevice(VmDeviceId id,
Line 291: VmDeviceType type,
Line 292: VmDeviceType device,
Line 293: Map<String, Object> specParams,
Line 294: boolean is_plugged,
please replace 'is_plugged' with 'plugged' to match java naming conventions.
Line 295: boolean isReadOnly,
Line 296: String address) {
Line 297: VmDevice managedDevice = addManagedDevice(id, type, device,
specParams,is_plugged,isReadOnly);
Line 298: if (StringUtils.isNotBlank(address)){
Line 291: VmDeviceType type,
Line 292: VmDeviceType device,
Line 293: Map<String, Object> specParams,
Line 294: boolean is_plugged,
Line 295: boolean isReadOnly,
s/isReadOnly/readOnly
Line 296: String address) {
Line 297: VmDevice managedDevice = addManagedDevice(id, type, device,
specParams,is_plugged,isReadOnly);
Line 298: if (StringUtils.isNotBlank(address)){
Line 299: managedDevice.setAddress(address);
--
To view, visit http://gerrit.ovirt.org/9087
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a0826a82aaec39425261c9030d99cd3b462832
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
