Liron Aravot has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 205: VdcBllErrors errorCode = e.getErrorCode();
Line 206:
Line 207: // if the returned exception is such that shoudn't
trigger the re-run process,
Line 208: // re-throw it. otherwise, continue (the vm will be
down and a re-run will be triggered)
Line 209: switch (errorCode) {
Seems to me that this line might be wrong, in case that the operation is Done i
don't think that there is an exception if i recall correctly. further more -you
will never get to the code in line 222 that set the operation to successful.
BTW- do you really have to re-throw the exception? why can't you set the
operation as failed or return boolean?
Line 210: case Done:
Line 211: case exist:
Line 212: throw e;
Line 213: default:
--
To view, visit http://gerrit.ovirt.org/9085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35569a2ebfbea3e8eb69b414c31748c49cb29841
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
