Allon Mureinik has posted comments on this change.
Change subject: core: lsm - live snapshots rollback
......................................................................
Patch Set 1: (1 inline comment)
see question inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
Line 27: }
Line 28:
Line 29: @Override
Line 30: public void execute() {
Line 31: if
(getEnclosingCommand().getParameters().getTaskGroupSuccess()) {
How can we get here if the task group hasn't succeeded?
Line 32: getReturnValue().setSucceeded(false);
Line 33: beforeTask();
Line 34: addTask(Backend.getInstance().getResourceManager()
Line 35: .RunVdsCommand(getVDSCommandType(),
getVDSParameters()));
--
To view, visit http://gerrit.ovirt.org/9142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24f9bc88623a9cd0addade874c7f2beeab67d423
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
