Allon Mureinik has posted comments on this change. Change subject: core: Fix possible NPE in VdsUpdateRunTimeInfo ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) In addition to Alon and Laszlo's questions, I think the implementation may have a problem - see inline comment. .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 1199: curVm.getmigrating_to_vds(), destroyCmd.getVDSReturnValue().getExceptionString()); Line 1200: } Line 1201: } Line 1202: // set vm status to down if source vm crushed Line 1203: ResourceManager.getInstance().InternalSetVmStatus(curVm, VMStatus.Down); This, eventually, calls vm.setrun_on_vds(null), which in turn calls vm.mVmDynamic.setrun_on_vds(null) - so if the dynamic data is null, you should also have an NPE here. Line 1204: AddVmDynamicToList(curVm.getDynamicData()); Line 1205: AddVmStatisticsToList(curVm.getStatisticsData()); Line 1206: AddVmInterfaceStatisticsToList(curVm.getInterfaces()); Line 1207: type = AuditLogType.VM_MIGRATION_ABORT; -- To view, visit http://gerrit.ovirt.org/9130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363780f669b54e1acd844473b2b30e7ae7840136 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
