Liron Aravot has posted comments on this change.
Change subject: core : WIP : Preview snapshot - NPE after engine crash
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 88: endActionOnDisks();
Line 89:
Line 90: if (getVm() != null) {
Line 91: VmHandler.unlockVm(getVm(), getCompensationContext());
Line 92: // TODO : this line is temporary until AsyncTaskManager
issues (missing tasks) would be solved,
I replied in the last patchset,
reset the compensation after the first task created won't help in that case and
will just cause inconsistency or redundant checks. - there is no meaning to the
new active snapshot in preview with only some of the disks. if endSuccesfully
would be called and succeed when there were tasks for only part of disks it
won't be actually a preview as some of the disks won't be in the new snapshot
which will cause to either inconsistent data on disk or bad user experience
(won't have some of his disks on the preview). this is not the solution on this
case at the moment.
Line 93: // as of today - endSuccessfully() will be called also in
case that tasks were initiated for some of the
Line 94: // disks regardless if there was a failure during the
initializtion of it.
Line 95: if
(getSnapshotDao().get(((ImagesActionsParametersBase)getParameters().getImagesParameters().get(0)).getVmSnapshotId())
!= null) {
Line 96: restoreVmConfigFromSnapshot();
--
To view, visit http://gerrit.ovirt.org/9073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ddecc990fbca23fb98e8ab42cb1eb039e1fb59
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
