Alon Bar-Lev has uploaded a new change for review. Change subject: utils: tests: tar: cleanup main() entry point ......................................................................
utils: tests: tar: cleanup main() entry point People found that this unused testing only code needs to not leak. Change-Id: I85ac69a75fdef1d5e60f7e33d79bc223535c01a0 Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/9166/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java index ffa423e..07588ad 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java @@ -131,13 +131,11 @@ Tar.doTar(os, new File(args[1])); } finally { - try { - if (os != null) { + if (os != null) { + try { os.close(); } - } - finally { - //ignore + catch(IOException e) {} } } } -- To view, visit http://gerrit.ovirt.org/9166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85ac69a75fdef1d5e60f7e33d79bc223535c01a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
