Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint() ......................................................................
Patch Set 1: The class is SSHClient, all the other internal is trivial. As I wrote in my previous comment, this will be merged into one place when we do the ssh fingerprint overall. For now, there is no point in keeping 4 lines common of SSHClient usage in separate class as it == to 4 lines of usage this common (assuming it will throw an exception on failure as it should, and ignoring exception will be in the outside code). -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
