Allon Mureinik has posted comments on this change.
Change subject: bootstrap: do not get unique id at canDoAction
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 356: sshclient = getSSHClient();
Line 357: sshclient.setHardTimeout(timeout);
Line 358: sshclient.setSoftTimeout(timeout);
Line 359: sshclient.setHost(vds.gethost_name());
Line 360: sshclient.setUser("root");
consider using a constant?
Line 361:
sshclient.setPassword(getParameters().getRootPassword());
Line 362: sshclient.connect();
Line 363: sshclient.authenticate();
Line 364: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 495: }
Line 496:
Line 497: public static List<VDS> getVdssByUniqueId(final Guid vdsId,
String uniqueIdToCheck) {
Line 498: List<VDS> list =
DbFacade.getInstance().getVdsDao().getAllWithUniqueId(uniqueIdToCheck);
Line 499: return LinqUtils.filter(list, new Predicate<VDS>() {
We're trying to limit the usages of LinqUtils. On the other hand, if this is
just moving old code around...
eh...
Line 500: @Override
Line 501: public boolean eval(VDS vds) {
Line 502: return !vds.getId().equals(vdsId);
Line 503: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java
Line 304: when(spyVdsCommand.getSSHClient()).thenReturn(sshclient);
Line 305: return spyVdsCommand;
Line 306: }
Line 307:
Line 308: private void mockSSHClient() {
just throw the exception upwards..
Line 309: try {
Line 310: doNothing().when(sshclient).connect();
Line 311: doNothing().when(sshclient).authenticate();
Line 312: }
--
To view, visit http://gerrit.ovirt.org/9159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0263dbae34aaa02c126c5ed1dc52a84f4f5e77f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
