Liron Aravot has posted comments on this change.
Change subject: core: compensate on wrong object leads to NPE
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 219: * @param vm
Line 220: * The VM to unlock.
Line 221: * @param compensationContext
Line 222: * Used to save the old VM status, for compensation
purposes.
Line 223: */
I agree and mentioned it, as this is used in VmCommand and basically all vms
commands it'll be removed in a further patch. this patch is about removing the
possible NPE that we have at the moment.
Line 224: public static void unlockVm(final VM vm, final
CompensationContext compensationContext) {
Line 225: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 226:
Line 227: @Override
--
To view, visit http://gerrit.ovirt.org/9074
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
