Yair Zaslavsky has posted comments on this change.
Change subject: core: Make connection timeout configurable
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 175: log.infoFormat("vdsBroker({0},{1})", _vds.gethost_name(),
_vds.getport());
Line 176:
Line 177: // Get the compatibility version of the cluster, as the
values of the
Line 178: // timeouts used depend on that:
Line 179: String clusterVersion = Config.DefaultConfigurationVersion;
Hi,
Thanks for elaborating on the previous patch :)
The problem with this code is -
a. It's not clear (but you were nice and explained ;) )
b. I understand the fear from NPE, and that we want to protect ourselves (as
more than 99% of exceptions are NPEs), but I really really don't see an options
that vds will not have compatibility version, but I may of course be wrong.
What do you think? as you understand my issue is with the String clusterVersion
= Config.DefaultConfigurationVersion; code.
Thanks!
Line 180: if (_vds != null) {
Line 181: clusterVersion =
_vds.getvds_group_compatibility_version().getValue();
Line 182: }
Line 183:
--
To view, visit http://gerrit.ovirt.org/8410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a49ae5d655c2105c5840decec81ae712e40c32
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
